build: Include Calico images in image list #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR/issue depends on:
|
This was referenced Sep 5, 2024
Merged
jimmidyson
force-pushed
the
faiq/get-images
branch
from
c35fdf8
to
d4bc869
Compare
jimmidyson
force-pushed
the
jimmi/calico-images
branch
from
43962f5
to
7cbd471
Compare
dkoshkin
approved these changes
Sep 5, 2024
faiq
reviewed
Sep 5, 2024
faiq
requested changes
Sep 5, 2024
supershal
reviewed
Sep 5, 2024
supershal
approved these changes
Sep 6, 2024
faiq
approved these changes
Sep 7, 2024
faiq
force-pushed
the
faiq/get-images
branch
from
892c6e4
to
d5f53bd
Compare
Calico images are deployed by the tigera-operator and as such are not discoverable by the helm list images plugin. Using the extra images file functionality of the helm list images plugin allows for adding these images as templated strings that will adapt with the chart version as it is updated in future. This commit also fixes up some other things: - Use `filepath` instead of `path` for portabiity - Output the image list to stdout from make to allow user to decide where to redirect list to - Omit changing dir from image list when running as goreleaser hook - Slightly more defensive when checkinbg errors
jimmidyson
force-pushed
the
jimmi/calico-images
branch
from
7cbd471
to
46e57a9
Compare
jimmidyson
added a commit
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calico images are deployed by the tigera-operator and as such are not
discoverable by the helm list images plugin. Using the extra images file
functionality of the helm list images plugin allows for adding these
images as templated strings that will adapt with the chart version as it
is updated in future.
This commit also fixes up some other things:
filepathinstead ofpathfor portabiitywhere to redirect list to
Final output is:
Depends on #822.